[Dxspider-support] defunkt sh/dx after migration to mojo

[Dirk Koopman]

Line 393 in Spot.pm should read:

     return sprintf "%8.1f  %-11s %s %s  %-28.28s%7s>", $_[0], $_[1], 
$d, $t, ($_[3]||''), "<$_[4]" ;

The only place the '$f1' is mentioned, anywhere in Spot.pm,  is in the 
comment starting at line 237:

# search the spot database for records based on the field no and an 
expression
# this returns a set of references to the spots
#
# the expression is a legal perl 'if' statement with the possible fields 
indicated
# by $f<n> where :-
#
#   $f0 = frequency
#   $f1 = call
#   $f2 = date in unix format
#   $f3 = comment
#   $f4 = spotter

It is NOT used as a variable (global or otherwise) in any module and 
command in the mojo branch of the code.  It is used in DXSql.pm, line 
167, as a constant string (not a variable). Furthermore that bit of code 
may (or more likely) may not work and it currently deprecated.

Please do a 'git diff mojo' and check that you have no differences.

Try 'git reset --hard'

Please tell us if any of this worked.

73 Dirk G1TLH

On 22/06/2020 17:15, rin JG1VGX via Dxspider-support wrote:

> Thanks for testing Kin-san,
>
> Forgot to mention that I'm running the latest version 1.57 (build 276
> git: mojo/ea366aef[r]) on Ubuntu 20.04.
>
> I'm also running another node with the same configuration which was
> upgraded (at the same time) to mojo without problem. (sh/dx with
> anything seems to work there)
>
> Strange!
>
> 73 rin JG1VGX
>
>
> On Tue, Jun 23, 2020 at 12:37 AM Joaquin . <joaquin at cronux.net> wrote:
>> Hi,
>>
>> I have 1.57 build 276, in this moment not a problem at 4 nodes.
>> sh/dx 10,  is OK
>> sh/dx by ja, also OK.
>>
>>
>> Kin EA3CV
>>
>>
>>
>>
>> El lun., 22 jun. 2020 17:10, rin JG1VGX via Dxspider-support <dxspider-support at tobit.co.uk> escribió:
>>> Hi Dirk-san and all,
>>>
>>> I have just updated my JG1VGX-9 cluster to the mojo branch according
>>> to the instructions.
>>>
>>> It works mostly, but strangely sh/dx with subcommands do not work.
>>>
>>> These works:
>>> sh/dx
>>> sh/dx 5
>>> sh/dx 5-10
>>> sh/dx day 3
>>>
>>> While these do NOT work:
>>> sh/dx by <call>
>>> sh/dx <prefix>
>>> sh/dx by_zone 25
>>> .... and almost everything else.
>>>
>>> They simply returns something like this:
>>> sh/dx by ja
>>> 0.0              22-Jun-2020 1503Z                                    <>
>>> 0.0              22-Jun-2020 1503Z                                    <>
>>> M0CFF de JG1VGX-9 22-Jun-2020 1503Z dxspider >
>>>
>>> watchdbg messages (please disregard timestamps)
>>> 14:15:59 (state) Global symbol "$f1" requires explicit package name
>>> (did you forget to declare "my $f1"?) at (eval 147) line 1.
>>> 14:15:59 (state) Use of uninitialized value $_[4] in concatenation (.)
>>> or string at /spider/perl/Spot.pm line 393.
>>> 14:15:59 (state)  at /spider/perl/Spot.pm line 393.
>>> 14:15:59 (state) Global symbol "$f1" requires explicit package name
>>> (did you forget to declare "my $f1"?) at (eval 147) line 1.
>>> 14:15:59 (state) Use of uninitialized value in sprintf at
>>> /spider/perl/Spot.pm line 393.
>>> 14:15:59 (state)  at /spider/perl/Spot.pm line 393.
>>> 14:15:59 (state) Global symbol "$f1" requires explicit package name
>>> (did you forget to declare "my $f1"?) at (eval 147) line 1.
>>> 14:15:59 (state) Use of uninitialized value in sprintf at
>>> /spider/perl/Spot.pm line 393.
>>> 14:15:59 (state)  at /spider/perl/Spot.pm line 393.
>>> 14:15:59 (state) Global symbol "$f1" requires explicit package name
>>> (did you forget to declare "my $f1"?) at (eval 147) line 1.
>>> 14:15:59 (state) Use of uninitialized value $_[4] in concatenation (.)
>>> or string at /spider/perl/Spot.pm line 393.
>>> 14:15:59 (state)  at /spider/perl/Spot.pm line 393.
>>> 14:15:59 (state) Global symbol "$f1" requires explicit package name
>>> (did you forget to declare "my $f1"?) at (eval 147) line 1.
>>> 14:15:59 (state) Use of uninitialized value in sprintf at
>>> /spider/perl/Spot.pm line 393.
>>> 14:15:59 (state)  at /spider/perl/Spot.pm line 393.
>>> 14:15:59 (state) Global symbol "$f1" requires explicit package name
>>> (did you forget to declare "my $f1"?) at (eval 147) line 1.
>>> 14:15:59 (state) Use of uninitialized value in sprintf at
>>> /spider/perl/Spot.pm line 393.
>>> 14:15:59 (state)  at /spider/perl/Spot.pm line 393.
>>>
>>> line 393 at Spot.pm:
>>> # format a spot for user output in list mode
>>> sub formatl
>>> {
>>>          my $t = ztime($_[2]);
>>>          my $d = cldate($_[2]);
>>>          return sprintf "%8.1f  %-11s %s %s  %-28.28s%7s>", $_[0],
>>> $_[1], $d, $t, ($_[3]||''), "<$_[4]" ;    <<=======
>>> }
>>>
>>> Any ideas?
>>> --
>>> 73 rin JG1VGX
>>>
>>> _______________________________________________
>>> Dxspider-support mailing list
>>> Dxspider-support at tobit.co.uk
>>> https://mailman.tobit.co.uk/mailman/listinfo/dxspider-support
>
>
> --
> 73 rin JG1VGX
>
> _______________________________________________
> Dxspider-support mailing list
> Dxspider-support at tobit.co.uk
> https://mailman.tobit.co.uk/mailman/listinfo/dxspider-support