[Dxspider-support] Can't build dxspider from source

[Kin]

Good job, Rui.
 
I ran into that same problem when I started with Docker, but I never bothered to fix it, maybe because I don't use it.
 
73 de Kin
EA3CV
 
De: Dxspider-support <dxspider-support-bounces at tobit.co.uk> En nombre de Rui Oliveira via Dxspider-support
Enviado el: martes, 7 de enero de 2025 18:50
Para: dxspider-support at tobit.co.uk
CC: Rui Oliveira <ruimail24 at gmail.com>
Asunto: Re: [Dxspider-support] Can't build dxspider from source
 
Hi again,

It's nice to know that the client binary isn't really needed anyway, but in the meanwhile, we have discovered the issue.

First, some context.

We use this repo to deploy dxspider: https://github.com/ruilvo/dxspider-deployment/
"updating" dxspider really means destroying the docker image and just pulling it up again.

So what was the problem?

The docker image was using `FROM alpine:latest` as the source image. Turns out that in some recent update alpine started shipping with GCC 14.

And this was the problem: the client binary does not build with GCC 14. This is because many warnings turned into hard errors. More info on: https://gcc.gnu.org/gcc-14/porting_to.html
On that page you find "Incorrect uses of the return statement (-Werror=return-mismatch)", which is the problem we first reported.

I played around a bit with the source code and there are other problems that prevent it from building with GCC 14.
Namely "Implicit function declarations (-Werror=implicit-function-declaration)", as the function `die` is never explicitly declared in some of the source files (other than the one where it is defined), and I remember something about how main is declared as well.

To fix this, some reworks is needed of the source code, or some flags to be added to the makefile (-fpermissive and -Wno-error=… for those options).

73,
CT7ALW
 
---------- Forwarded message ---------
From: Kin <ea3cv at cronux.net <mailto:ea3cv at cronux.net> >
Date: Sun, Jan 5, 2025 at 1:34 PM
Subject: RE: [Dxspider-support] Can't build dxspider from source
To: The DXSpider Support list <dxspider-support at tobit.co.uk <mailto:dxspider-support at tobit.co.uk> >
Cc: CT2IWW <ct2iww at gmail.com <mailto:ct2iww at gmail.com> >
 
The client.c can be compiled once spider has been updated, it is not a problem for the node not to work, and it is not necessary either.
 
Kin
 
EA3CV-2 dxcluster.cronux.net <http://dxcluster.cronux.net>  7300
https://clustermap.cronux.net/map.html
https://clustermap.cronux.net/route_finder.html
 
De: Dxspider-support <dxspider-support-bounces at tobit.co.uk <mailto:dxspider-support-bounces at tobit.co.uk> > En nombre de CT2IWW via Dxspider-support
Enviado el: domingo, 5 de enero de 2025 14:14
Para: dxspider-support at tobit.co.uk <mailto:dxspider-support at tobit.co.uk> 
CC: CT2IWW <ct2iww at gmail.com <mailto:ct2iww at gmail.com> >
Asunto: [Dxspider-support] Can't build dxspider from source
 
Hi everyone,

We were updating dxspider, and faced with the following build error:

  => [cluster 13/19] RUN git clone -b mojo 
git://scm.dxcluster.org/scm/spider <http://scm.dxcluster.org/scm/spider>  /spider 8.4s
  => [cluster 14/19] RUN mkdir -p /spider/local /spider/local_cmd 
/spider/local_data 0.2s
  => [cluster 15/19] RUN find /spider/. -type d -exec chmod 2775 {} ; 
&&     find /spider/. -type f -name '*.pl' -exec chmod 775 {} 
;                                                    0.8s
  => ERROR [cluster 16/19] RUN (cd /spider/src && make) 0.2s
------
  > [cluster 16/19] RUN (cd /spider/src && make):
0.176 cc -g -O   -c -o client.o client.c
0.200 client.c: In function 'fcb_handler':
0.200 client.c:558:41: error: 'return' with no value, in function 
returning non-void [-Wreturn-mismatch]
0.200   558 |                                         return;
0.200       |                                         ^~~~~~
0.200 client.c:356:5: note: declared here
0.200   356 | int fcb_handler(sel_t *sp, int in, int out, int err)
0.200       |     ^~~~~~~~~~~
0.206 client.c: At top level:
0.206 client.c:864:1: error: return type defaults to 'int' [-Wimplicit-int]
0.206   864 | main(int argc, char *argv[])
0.206       | ^~~~
[+] Running 0/1 [<builtin>: client.o] Error 1
  ⠴ Service cluster Building 21.6s
failed to solve: process "/bin/sh -c (cd ${SPIDER_INSTALL_DIR}/src && 
make)" did not complete successfully: exit code: 2

Seems that the `mojo` branch has a broken build. Can this be fixed?

Thank you, 73, and HNY.
 
Paulo CT2IWW
Rui CT7ALW
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.tobit.co.uk/pipermail/dxspider-support/attachments/20250107/6c1abda8/attachment-0001.htm>